Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Derived Fields] PR4: Capability to define derived fields in search request #13163

Merged
merged 2 commits into from
Apr 11, 2024
Merged

[Backport 2.x] [Derived Fields] PR4: Capability to define derived fields in search request #13163

merged 2 commits into from
Apr 11, 2024

Conversation

rishabhmaurya
Copy link
Contributor

@rishabhmaurya rishabhmaurya commented Apr 11, 2024 •
edited
Loading

Description

Backport 645b1f1 from #12850.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions bot and others added 2 commits April 11, 2024 17:01
@github-actions
[Derived Fields] PR4: Capability to define derived fields in search r…
31fc5a3 
…equest (opensearch-project#12850)

* Support derived fields definition in search request
* adds support for fetch phase on derived fields
* adds support for highlighting on derived fields

---------

Signed-off-by: Rishabh Maurya <[email protected]>
(cherry picked from commit 645b1f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@rishabhmaurya
fix the version for backward compatibility
95f59e3 
Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya rishabhmaurya mentioned this pull request Apr 11, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 95f59e3

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 95f59e3: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 71.83099% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 71.22%. Comparing base (0dd892c) to head (95f59e3).
Report is 127 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/index/mapper/DerivedFieldType.java 66.66% 14 Missing ⚠️
...rg/opensearch/index/mapper/DerivedFieldMapper.java 50.00% 9 Missing ⚠️
...main/java/org/opensearch/search/SearchService.java 58.82% 4 Missing and 3 partials ⚠️
...opensearch/search/builder/SearchSourceBuilder.java 81.08% 0 Missing and 7 partials ⚠️
...java/org/opensearch/index/mapper/DerivedField.java 79.31% 6 Missing ⚠️
...earch/index/mapper/DerivedFieldSupportedTypes.java 60.00% 4 Missing and 2 partials ⚠️
...opensearch/action/search/SearchRequestBuilder.java 0.00% 2 Missing ⚠️
...nsearch/index/mapper/DerivedFieldValueFetcher.java 88.23% 1 Missing and 1 partial ⚠️
.../org/opensearch/index/query/DerivedFieldQuery.java 71.42% 2 Missing ⚠️
.../org/opensearch/index/query/QueryShardContext.java 88.88% 0 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13163      +/-   ##
============================================
- Coverage     71.28%   71.22%   -0.06%     
- Complexity    60145    60614     +469     
============================================
  Files          4957     5001      +44     
  Lines        282799   285160    +2361     
  Branches      41409    41689     +280     
============================================
+ Hits         201591   203118    +1527     
- Misses        64189    64858     +669     
- Partials      17019    17184     +165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh
Copy link
Collaborator

msfroh commented Apr 11, 2024

Looks good ! I'll merge this as soon as we have the (broken) version update PR for main to switch the version checks to 2.14 over there too.

@rishabhmaurya
Copy link
Contributor Author

have created - #13168

@msfroh msfroh merged commit bcd2d8a into opensearch-project:2.x Apr 11, 2024
57 of 58 checks passed
@msfroh msfroh mentioned this pull request Apr 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishabhmaurya @msfroh